Skip to content

🩹 [Hotfix] Add setter for tokenizer#2163

Merged
qgallouedec merged 1 commit intomainfrom
hotfix-set-tokenizer
Oct 3, 2024
Merged

🩹 [Hotfix] Add setter for tokenizer#2163
qgallouedec merged 1 commit intomainfrom
hotfix-set-tokenizer

Conversation

@qgallouedec
Copy link
Member

What does this PR do?

Fixes #2161

The next step is to make the same modification as in Transformers: #2162

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec changed the title 🩹 [HOTfix] Add setter for tokenizer 🩹 [Hotfix] Add setter for tokenizer Oct 3, 2024
@qgallouedec
Copy link
Member Author

Can be reverted when huggingface/transformers#33911 is merged

@qgallouedec qgallouedec merged commit 1be4d86 into main Oct 3, 2024
@qgallouedec qgallouedec deleted the hotfix-set-tokenizer branch October 3, 2024 14:13
qgallouedec added a commit that referenced this pull request Oct 3, 2024
yxliu-TAMU pushed a commit to mincheolseong/ECEN743-GRPO-Project-Proposal that referenced this pull request Apr 20, 2025
yxliu-TAMU pushed a commit to mincheolseong/ECEN743-GRPO-Project-Proposal that referenced this pull request Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: property 'tokenizer' of 'DPOTrainer' object has no setter

4 participants